cellrendererspinner: Don't track old icon size
authorBenjamin Otte <otte@redhat.com>
Mon, 23 Jan 2017 18:59:27 +0000 (19:59 +0100)
committerMatthias Clasen <mclasen@redhat.com>
Wed, 15 Nov 2017 19:22:17 +0000 (14:22 -0500)
It was only used to avoid gtk_icon_size_lookup() calls and those aren't
expensive.

gtk/gtkcellrendererspinner.c

index 527a7455b81a2d9f746ddc2c9aece753f9a1cc3c..54b1cbd11cfeb5a0e643bd4fe7318b6d877d2049 100644 (file)
@@ -66,7 +66,7 @@ struct _GtkCellRendererSpinnerPrivate
 {
   gboolean active;
   guint pulse;
-  GtkIconSize icon_size, old_icon_size;
+  GtkIconSize icon_size;
   gint size;
 };
 
@@ -162,7 +162,6 @@ gtk_cell_renderer_spinner_init (GtkCellRendererSpinner *cell)
 {
   cell->priv = gtk_cell_renderer_spinner_get_instance_private (cell);
   cell->priv->pulse = 0;
-  cell->priv->old_icon_size = GTK_ICON_SIZE_INVALID;
   cell->priv->icon_size = GTK_ICON_SIZE_MENU;
 }
 
@@ -188,9 +187,6 @@ gtk_cell_renderer_spinner_update_size (GtkCellRendererSpinner *cell,
 {
   GtkCellRendererSpinnerPrivate *priv = cell->priv;
 
-  if (priv->old_icon_size == priv->icon_size)
-    return;
-
   if (!gtk_icon_size_lookup (priv->icon_size, &priv->size, NULL))
     {
       g_warning ("Invalid icon size %u", priv->icon_size);
@@ -251,7 +247,6 @@ gtk_cell_renderer_spinner_set_property (GObject      *object,
       case PROP_SIZE:
         if (priv->icon_size != g_value_get_enum (value))
           {
-            priv->old_icon_size = priv->icon_size;
             priv->icon_size = g_value_get_enum (value);
             g_object_notify (object, "size");
           }